Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] updated artifact script #466

Merged
merged 1 commit into from
Jun 11, 2021

Conversation

kavilla
Copy link
Member

@kavilla kavilla commented Jun 9, 2021

Description

Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Signed-off-by: Kawika Avilla [email protected]

Issues Resolved

#242
#19

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed c53daf9

@kavilla kavilla added the v1.0.0 label Jun 9, 2021
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed ca98a81

@kavilla kavilla force-pushed the avillk/update_artifactjs branch from ca98a81 to 8fc5fe7 Compare June 10, 2021 22:21
@kavilla kavilla requested a review from tmarkley June 10, 2021 22:22
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed 8fc5fe7

Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
opensearch-project#242
opensearch-project#19

Signed-off-by: Kawika Avilla <[email protected]>
@kavilla kavilla force-pushed the avillk/update_artifactjs branch from 8fc5fe7 to bf0097a Compare June 11, 2021 02:50
@kavilla kavilla requested a review from tmarkley June 11, 2021 02:51
@opensearch-ci-bot
Copy link
Collaborator

✅   DCO Check Passed bf0097a

Copy link
Contributor

@tmarkley tmarkley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@boktorbb boktorbb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kavilla kavilla merged commit daa686f into opensearch-project:main Jun 11, 2021
@kavilla kavilla deleted the avillk/update_artifactjs branch June 12, 2021 02:39
kavilla added a commit that referenced this pull request Jun 21, 2021
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
#242
#19

Signed-off-by: Kawika Avilla <[email protected]>
kavilla added a commit that referenced this pull request Jun 21, 2021
Updating artifact to enable running integration tests and functional
tests to pull an artifact from the current hosted distributions.

At the time of this commit, there is not manifest hosted but there are
static links which can have an unknown amount of RC versions if the
GA snapshot does not exist for that version. But the assumption
is that it will not be too high.

Deprecating the previous implementation but we can remove that in a
future iteration. Wanted to leave that available incase others use
that for custom manifests.

Enable tests that depended on snapshots as well.

Issues resolved:
#242
#19

Signed-off-by: Kawika Avilla <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants